-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log errno names instead of values #49
Conversation
@@ -677,14 +678,14 @@ const char * inet_ntop6(const u_char *src, char *dst, size_t size); | |||
//adapted from freebsd inet_ntop.c(1.12) and inet_pton.c(1.5) for windows(non-compliant snprinf workaround) | |||
/* const char * | |||
* inet_ntop4(src, dst, size) | |||
* format an IPv4 address, more or less like inet_ntoa() | |||
* format an IPv4 address, more or less like inet_ntoa() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't include these formatting changes
I've had a closer look at this On Windows, the error names and numbers are different: What I'd like to see in Errdes.hxx:
|
Ok, working on it. |
for now, just create the classes, don't worry about changing all the other code to use them yet. Let me look at the classes you create and we'll refine them before you change all the other code. |
Please visit https://github.com/udit043/resiprocate/tree/patch-6 |
Udit, can you please create a new pull request for me to comment on? |
Please visit https://github.com/udit043/resiprocate/tree/patch-6.
I have created new branch for this task. After discussion with mentor will close and create new pull request.